Fix generate_catalog_edc_code triggered on every build #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fineg74
approved these changes
Jun 9, 2021
| # creates dependencies on the generated code which would causes this target to be automatically | ||
| # called. | ||
| add_custom_command( | ||
| COMMENT "Generating EDC code for database catalog..." |
There was a problem hiding this comment.
Indentation is off.
There was a problem hiding this comment.
Fixed in my local branch. The fix will come in the next PR.
| COMMAND cp ${GAIA_GENERATED_CODE}/catalog/gaia_catalog.h ${GAIA_REPO}/production/inc/gaia_internal/catalog/ | ||
| COMMAND cp ${GAIA_GENERATED_CODE}/catalog/catalog_generated.h ${GAIA_REPO}/production/inc/gaia_internal/catalog/ | ||
| DEPENDS edc_catalog_discard | ||
| # make generate_catalog_edc_code |
There was a problem hiding this comment.
This comment seems rather redundant.
| DEPENDS edc_catalog_discard | ||
| # make generate_catalog_edc_code | ||
| add_custom_target(generate_catalog_edc_code | ||
| COMMENT "Copying generated EDC code for catalog into Gaia source tree..." |
There was a problem hiding this comment.
Indentation got messed up here too. Is your editor set incorrectly for make files?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem in the
generate_catalog_edc_codetarget that caused the catalog EDC code to always be generated triggering a huge part of the build.