Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a clang-tidy warning in ddl execution #745

Merged
merged 1 commit into from
Jun 20, 2021

Conversation

chuan
Copy link
Contributor

@chuan chuan commented Jun 20, 2021

Dynamic casting on an intermediate pointer causes clang-tidy to complain: "Forming reference to null pointer". Using the iterator directly fixes the issue.

@chuan chuan requested a review from senderista June 20, 2021 02:00
Copy link
Contributor

@senderista senderista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chuan chuan merged commit dea24ce into master Jun 20, 2021
@chuan chuan deleted the ddl-execution-clang-tidy-fix branch June 20, 2021 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants