Persist unique constraint setting in catalog #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuan
requested review from
yiwen-wong,
simone-gaia,
daxhaw,
LaurentiuCristofor and
senderista
|
|
||
| // Creating an unique index on a single field automatically makes the field | ||
| // unique. Do nothing for multiple-filed index creation because we do not | ||
| // support unique constraints for composite keys at the moment. |
There was a problem hiding this comment.
Should an error be given in the composite keys case?
There was a problem hiding this comment.
No, because we do support composite key indexes.
simone-gaia
reviewed
Jun 23, 2021
Comment on lines
+46
to
+52
| ASSERT_TRUE(gaia_table_t::list() | ||
| .where(gaia_table_expr::name == "t") | ||
| .begin() | ||
| ->gaia_fields() | ||
| .where(gaia_field_expr::name == "c") | ||
| .begin() | ||
| ->unique()); |
There was a problem hiding this comment.
Interesting usage of the filter API!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new unique setting for the
fieldtable in catalog. Set the field as unique in catalog when creating tables or when creating an unique index on the field.