Force generate_catalog_edc_code to always re-run gaiac. #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generate_catalog_edc_code cannot depend on gaia targets otherwise it would always be built. The side effect is that the latest generated files are always considered fresh, therefore, if you change the catalog schema and call generate_catalog_edc_code the old files are picked instead of being regenerated. To resolve this issue, I delete the generated catalog files right after copying them in the Gaia source tree.
simone-gaia
requested review from
chuan,
senderista,
LaurentiuCristofor and
daxhaw
daxhaw
approved these changes
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generate_catalog_edc_code cannot depend on gaia targets otherwise it would always be built. The side effect is that the latest generated files are always considered fresh, therefore, if you change the catalog schema and call generate_catalog_edc_code the old files are picked instead of being regenerated.
To resolve this issue, I delete the generated catalog files right after copying them in the Gaia source tree.