Fix gdev build #763
Merged
Fix gdev build #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The default diff is a bit confusing because this PR includes both a revert-revert and an actual change. Here's the commit that works around the gdev parsing issue: d9d9481 |
daxhaw
approved these changes
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a comment with embedded braces to a
gdev.cfgfile, which made thegdevparser very confused because it blindly performed variable substitution on the text enclosed by the braces. This change removes braces from that comment and reverts the revert I made of my previous build fix (which was only done to narrow down the cause of this build break).I created https://gaiaplatform.atlassian.net/browse/GAIAPLAT-1035 to track the
gdev.cfgparsing issue.