Fix operation of MPSC queue #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senderista
approved these changes
Jul 12, 2021
simone-gaia
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue I introduced when I modified the code of the MPSC queue. I added comments to explain the situations addressed by the checks in the code and I fixed the url which pointed to a different implementation.
Note: the issue was not hit so far because the way the queue is used right now avoids the special case when an issue could manifest: we're currently only extracting data from the queue when we accumulated enough and we don't attempt to extract the last element (this was originally done to avoid unnecessary producer-consumer concurrency conflicts).