Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in Cmake schema handling code, add test for 1:1 relationship in EDC expressions. #780

Merged
merged 2 commits into from
Jul 13, 2021

Conversation

simone-gaia
Copy link
Contributor

  • Fix bug that prevented modified DDL files to be updated in the Cmake binary folder
  • Add expression tests for 1:1 relationships

(Totally unrelated with everything I'm doing. Just some lazy job I could do from my flight)

COPY ${SCHEMA_FILES}
DESTINATION "${CMAKE_CURRENT_BINARY_DIR}/"
)
foreach(SCHEMA_FILE ${SCHEMA_FILES})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the bug that was fixed? From the title, it sounded like the bug was in the code, not in the build.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, updated the title.

@simone-gaia simone-gaia changed the title Fix bug in schema_loader, add test for 1:1 relationship in EDC expressions. Fix bug in Cmake schema handling code, add test for 1:1 relationship in EDC expressions. Jul 13, 2021
@simone-gaia simone-gaia merged commit 005a9cf into master Jul 13, 2021
@simone-gaia simone-gaia deleted the rondelli-edc-fp branch August 11, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants