Flatbuffer definitions for index queries #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senderista
suggested changes
Aug 10, 2021
| @@ -29,9 +29,19 @@ table table_scan_info_t { | |||
| type_id: uint64; | |||
| } | |||
|
|
|||
| enum index_query_type_t:uint8 { | |||
| } | ||
|
|
||
| table index_range_query_t { | ||
| query_type : index_query_type_t; |
There was a problem hiding this comment.
Please use existing convention foo: bar (this shows we need a precommit hook to autoformat .fbs files, because I hate bringing up these nits).
| table index_scan_info_t { | ||
| index_id: uint64; | ||
| txn_id : uint64; | ||
| queries : [index_range_query_t]; |
There was a problem hiding this comment.
Why do we need multiple queries per index scan?
There was a problem hiding this comment.
To specify upper bound and lower bound mostly
There was a problem hiding this comment.
Come to think of it I can do a real union type for that one.
|
Long-term question: for range queries, do we want to store sortkeys in the index rather than raw key values? If we can use binary comparison rather than locality-sensitive collation, that could potentially be a huge perf win. |
senderista
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For preview we are only supporting POINT_READs,
Eventually support for UPPER, LOWER, EQUALS range query will be supported.