Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://gaiaplatform.atlassian.net/browse/GAIAPLAT-1137 : Renaming tests to be consistent, removing old tests, adding README.md for tests. #822

Merged
merged 58 commits into from
Aug 10, 2021

Conversation

JackAtGaia
Copy link

@JackAtGaia JackAtGaia commented Aug 10, 2021

With the exception of a 1-line change to allow blank lines in test suite files, the rest of this PR is all about cleaning up the tests and suites.

  • two tests were no longer being used, and they were deleted
  • the names of the base tests has changed, so changed the *-1k, *-10k etc tests to use the new name
  • each test gets its own README.md
  • added blank line support for suite files to allow for cleaner looking files

p.s. I have no clue why this PR says there are 58 commits in it... there are 2-3 at most.

JackAtGaia added 30 commits July 7, 2021 15:31
@JackAtGaia JackAtGaia changed the title Merge test https://gaiaplatform.atlassian.net/browse/GAIAPLAT-1137 : Renaming tests to be consistent, removing old tests, adding README.md for tests. Aug 10, 2021
@JackAtGaia JackAtGaia requested a review from daxhaw August 10, 2021 21:57
@JackAtGaia JackAtGaia self-assigned this Aug 10, 2021
@JackAtGaia JackAtGaia marked this pull request as ready for review August 10, 2021 21:58
Copy link
Contributor

@simone-gaia simone-gaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants