Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://gaiaplatform.atlassian.net/browse/GAIAPLAT-1165 : Test Cleanu… #826

Merged
merged 2 commits into from
Aug 12, 2021

Conversation

JackAtGaia
Copy link

…p and updating readme.

Just some cleanup.

Copy link
Contributor

@senderista senderista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you update the README for the output changes you just made?

Copy link
Contributor

@phillipov phillipov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested a few sentence structure changes to make things shorter.

test/README.md Outdated Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
test/README.md Outdated
Comment on lines 331 to 332
they are executing. Regardless of whether it is a single test or a group of tests, that first
level element is always the name of that test. After that, there is some divergence
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
they are executing. Regardless of whether it is a single test or a group of tests, that first
level element is always the name of that test. After that, there is some divergence
they are executing. Regardless of whether it is a single test or a group of tests, that
first-level element is always the name of that test. After that, there is some divergence

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed level to make it clearer.

test/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@daxhaw daxhaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a check about whether you meant to include empty files as part of this PR? Maybe this is just a github UI thing but I see some of your expected output files were deleted and some remain as empty files. Was this intentional?

@JackAtGaia
Copy link
Author

@daxhaw Empty files. They were to get started, but one of the proposed changes is to clear those out, only having those files there if there is indeed something to compare to.

@JackAtGaia JackAtGaia merged commit bead3b2 into master Aug 12, 2021
JackAtGaia added a commit that referenced this pull request Aug 12, 2021
… project name changes (#829)

* https://gaiaplatform.atlassian.net/browse/GAIAPLAT-1165 : Test Cleanup and updating readme.

* #826 : Changes requested by Phillip

* https://gaiaplatform.atlassian.net/browse/GAIAPLAT-1166 : Changing 'incubator' workload to 'mink'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants