-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
https://gaiaplatform.atlassian.net/browse/GAIAPLAT-1165 : Test Cleanu… #826
Conversation
…p and updating readme.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you update the README for the output changes you just made?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested a few sentence structure changes to make things shorter.
test/README.md
Outdated
they are executing. Regardless of whether it is a single test or a group of tests, that first | ||
level element is always the name of that test. After that, there is some divergence |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they are executing. Regardless of whether it is a single test or a group of tests, that first | |
level element is always the name of that test. After that, there is some divergence | |
they are executing. Regardless of whether it is a single test or a group of tests, that | |
first-level element is always the name of that test. After that, there is some divergence |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed level to make it clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a check about whether you meant to include empty files as part of this PR? Maybe this is just a github UI thing but I see some of your expected output files were deleted and some remain as empty files. Was this intentional?
@daxhaw Empty files. They were to get started, but one of the proposed changes is to clear those out, only having those files there if there is indeed something to compare to. |
… project name changes (#829) * https://gaiaplatform.atlassian.net/browse/GAIAPLAT-1165 : Test Cleanup and updating readme. * #826 : Changes requested by Phillip * https://gaiaplatform.atlassian.net/browse/GAIAPLAT-1166 : Changing 'incubator' workload to 'mink'
…p and updating readme.
Just some cleanup.