Add instructions for how to add a diagnostic to gaiat #843
Conversation
| // 2) Use 'gaiat::diag().emit(...)' to get the diagnostics engine and pass in the error string. The IDs and other info | ||
| // are generated from the DiagnosticsSemaKinds.td file and put into the 'diag' namespace. | ||
| // | ||
| // 3) You can set the source location to give the user line and column information about the error. This can |
There was a problem hiding this comment.
I'm confused about what we mean by "user line".
Should to give the user line and column information about the error be to give line and column information about the error to the user?
Or is there some other word missing there?
There was a problem hiding this comment.
I should probably specify line and column number information. And 'user' really means the rule author.
There was a problem hiding this comment.
This reminds me that we should specify that the line and column number are relative to the ruleset file and not the generated cpp. I remember there was some uncertainty about this.
There was a problem hiding this comment.
Good point. Updated the text to make this more clear.
…rning group for gaia extensions
| @@ -10,6 +10,32 @@ | |||
| #include "clang/Basic/Diagnostic.h" | |||
| #pragma clang diagnostic pop | |||
|
|
|||
| // When adding errors strings to the translation engine, please use the llvm | |||
|
Thanks @LaurentiuCristofor and @simone-gaia |
Should have included instructions on how to add errors to gaiat going forward in the last PR.
Note: I'm also using this PR to push in a fix for an llvm-test break. I added a warning group for GaiaExtensions (gaia-extensions)