Changes to test-framework introduced during last 2 days of debugging. #845
Conversation
…ty to specify new package to install.
…ll capability into own script.
…into jack/reset-db
JackAtGaia
requested review from
chuan,
daxhaw,
fineg74,
jc-gaiaplatform,
LaurentiuCristofor,
mihirj1993,
phillipov,
senderista,
simone-gaia,
stevegaia,
tengizk,
waynelwarren and
yiwen-wong
| @@ -71,6 +71,20 @@ parse_command_line() { | |||
| done | |||
| } | |||
|
|
|||
| # Make sure that we do not have any instances running, not even as | |||
There was a problem hiding this comment.
Why is test not under production? All production-related tests should be under production folder, not under a top-level test folder?
Any test should be located under the folder of the specific product that is being tested, not separated from that.
| @@ -421,6 +421,10 @@ int wait_for_processing_to_complete(bool is_explicit_pause, int rule_1_sample_ba | |||
| const int no_delta_count_before_break = 300 / c_processing_pause_in_microseconds; | |||
| int current_no_delta_attempt = 0; | |||
|
|
|||
| char buffer[4096]; | |||
| int space_left = 1024; | |||
| char * start_pointer = buffer; | |||
There was a problem hiding this comment.
Because test is not under production, this code is not subject to the cleanup we do via clang-tidy. One of the benefits of having this code under production is that all formatting issues that can be handled automatically by clang-tidy, actually do get handled by it.
There was a problem hiding this comment.
which is why I have ./lint.sh which I run before each commit. are you spotting a formatting error that it missed?
test/proposal.md
Outdated
| @@ -0,0 +1,93 @@ | |||
| # Directory Reset Proposal | |||
|
|
|||
| Based on feedback provided by Dax, I have thought very | |||
There was a problem hiding this comment.
Check the production README guidelines for md files. In particular, we should not break long lines.
There was a problem hiding this comment.
this is a temporary file, and should not have been included in the commit.
There was a problem hiding this comment.
That is fine, but you should still check the guidelines for future reference. :)
Various small changes:
psfor any instances of gaia database before installingtest/utils/monitor_lsof.shto package up the FD tracking used for Tobin (also to establish a good pattern for these)test/utilsdirectory tolint.shmink.cpp, will break the test on purpose as the timeout should never occurexpected_output.jsonforsmoketest comparison