Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GAIAPLAT-1195 : Phase 1 #860

Merged
merged 2 commits into from
Aug 23, 2021
Merged

GAIAPLAT-1195 : Phase 1 #860

merged 2 commits into from
Aug 23, 2021

Conversation

JackAtGaia
Copy link

https://gaiaplatform.atlassian.net/browse/GAIAPLAT-1195

This ticket is to separate out the base framework from the workload. Basically, untangle the "mink" workload from the "framework" and make each one standalone.

Phase 1 is to logically separate the framework. Phase 2 will be to move the "mink" workload to its own directory and have it be referenced generically from the framework.

Highlights:

  • all suites moved into the "suite-definitions" directory
  • all python functions prefaced with "__" where having that function be public was not necessary
  • summarize_results.py renamed to summarize_suite_results.py
  • test related portions of summarize_results.py removed and placed in summarize_test_results.py
  • adding workload.properties file to specify what should be aggregated in the summary.json and to specify what should be shown for performance tests in the stats output

Copy link
Contributor

@simone-gaia simone-gaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nit: can you change the title to reflect what this PR is about ("Separate out workloads from base framework.")

main_dictionary[PER_MEASURED_DURATION_TITLE] = []
main_dictionary[T_OVER_PERCENT_TITLE] = []
for aggregate_key in aggregate_data:
assert aggregate_key not in main_dictionary[PER_TEST_TITLE]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you print a message if the assert fails suggesting what is wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants