GAIAPLAT-1195 : Following logical split, separating workload files from framework files. #863
Conversation
…ogical split, separating workload files from framework files.
JackAtGaia
requested review from
simone-gaia,
chuan,
daxhaw,
fineg74,
jc-gaiaplatform,
kenneth-gaia,
LaurentiuCristofor,
mihirj1993,
stevegaia,
tengizk,
waynelwarren and
yiwen-wong
production/tests/lint.sh
Outdated
| SCRIPTPATH="$( cd -- "$(dirname "$0")" >/dev/null 2>&1 ; pwd -P )" | ||
| # shellcheck disable=SC1091 source=./properties.sh | ||
| source "$SCRIPTPATH/properties.sh" | ||
| #SCRIPTPATH="$( cd -- "$(dirname "$0")" >/dev/null 2>&1 ; pwd -P )" |
There was a problem hiding this comment.
did you mean to leave a commented line in?
| A.value = adjust_temperature(incubator.min_temp, incubator.max_temp, S.value, A.value); | ||
| A.timestamp = g_timestamp; | ||
| } | ||
| actuator.value = adjust_temperature(incubator.min_temp, incubator.max_temp, sensor.value, actuator.value); |
There was a problem hiding this comment.
I don't recall our conversation, why not write it with the for loop?
There was a problem hiding this comment.
I saw a couple of issues with this when I was testing it. One of my tasks for today is to see if those changes are introducing stable, and document them if they are.
| @@ -0,0 +1,314 @@ | |||
| #! /usr/bin/bash | |||
There was a problem hiding this comment.
I guess I don't understand the split here. Shouldn't this be part of the framework, not the workload, and thus not under a mink subdirectory? Same with build.sh, install.sh, etc. Where the main framework just adds on command line arguments for the workload?
There was a problem hiding this comment.
conversation had. will proceed along this path for now.
| @@ -0,0 +1,161 @@ | |||
| #! /usr/bin/python3 | |||
|
|
|||
There was a problem hiding this comment.
same question about this file. Isn't this framework and not specific to the mink workload? Except for parameters that I could see driving this generation?
…k' hardcoding from framework.
…into jack/move-workload
https://gaiaplatform.atlassian.net/browse/GAIAPLAT-1195
Following the first phase of this ticket, which performed a logical separation between the two parts, this phase specifically separates the files into those two parts.
Notes: