Implement navigation implicit tags, Bug fixes for GAIAPLAT-1151,1188,1164,1191,1180,1172,796,803 #878
Conversation
* New/modified tests for implicit queries * correct a condition in a rule
…into ExplicitNavigationImplicitTags
…mplicitTags # Conflicts: # production/tools/gaia_translate/src/main.cpp
…#867) * New/modified tests for implicit queries * correct a condition in a rule * Tests updated for recent features/fixes * test annotations after cross-checking with Jira * removed ifdef around one fixed test
…into ExplicitNavigationImplicitTags
…mplicitTags # Conflicts: # .gitignore
| @@ -2124,6 +2156,7 @@ static bool validateRuleAttribute(StringRef attribute, | |||
| { | |||
| if (returnValue) | |||
| { | |||
| llvm::errs()<<"0\n"; | |||
There was a problem hiding this comment.
This seems a forgotten debug line.
…mplicitTags # Conflicts: # production/schemas/test/prerequisites/prerequisites.ddl
| @@ -45,6 +45,8 @@ checks.json | |||
|
|
|||
| # Integration/Performance Test files. | |||
| production/tests/Pipfile.lock | |||
|
|
|||
| third_party/production | |||
There was a problem hiding this comment.
It is not my change. Either merge artifact or Wayne change
| gaia::db::commit_transaction(); | ||
|
|
||
| gaia::rules::test::wait_for_rules_to_complete(); | ||
|
|
||
| ASSERT_EQ(g_test_mixed_value, 2); | ||
| ASSERT_EQ(g_test_mixed_value, 0); |
There was a problem hiding this comment.
Btw, in PR-882, I have changed the rules engine so it won't even fire the rule if the anchor row is invalid. So you could remove any code to check for a valid anchor.
There was a problem hiding this comment.
This PR is also a reminder that I need to fixup these gaia_translate tests as I probably broke them.
There was a problem hiding this comment.
It is Wayne's change
| @@ -33,7 +33,7 @@ ruleset test4 | |||
| } | |||
|
|
|||
| // TESTCASE: break from multiple outer loops from implicit query | |||
| // GAIAPLAT-1073 | |||
| // GAIAPLAT-1073 (won't do) | |||
There was a problem hiding this comment.
If these are won't do should we just remove the tests? (Probably a Wayne question?)
| @@ -45,7 +42,7 @@ ruleset test16 | |||
| ruleset test17 | |||
| { | |||
| { | |||
| x.value++; // expected-error {{Table 'x' was not found in the catalog. Ensure that the table you are referencing in your rule exists in the database.}} \ | |||
| x.value++; // expected-error {{Table 'x' was not found in the catalog}} \ | |||
There was a problem hiding this comment.
I don't see a change to the error message in DiagnosticSemaKinds.td won't this fail the llvm-test? (err_table_not_found has the message about ensuring the table exists in the database).
…mplicitTags # Conflicts: # production/schemas/test/prerequisites/prerequisites.ddl
No description provided.