ENABLE_CLANG_TIDY option for build #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simone-gaia
reviewed
Sep 1, 2021
production/CMakeLists.txt
Outdated
| @@ -21,6 +21,8 @@ option(EXECUTE_FDW_TESTS "Execute FDW tests" OFF) | |||
|
|
|||
| option(ENABLE_STACKTRACE "Enable stack traces" ON) | |||
|
|
|||
| option(ENABLE_CLANG_TIDY "Enable clang tidy" ON) | |||
There was a problem hiding this comment.
You know what, I would make it the default only on debug builds (if it's not too trouble). That will definitely save time on TeamCity that is starting to be crowded...
simone-gaia
approved these changes
Sep 1, 2021
simone-gaia
reviewed
Sep 1, 2021
| if(CMAKE_BUILD_TYPE STREQUAL "Debug") | ||
| option(ENABLE_CLANG_TIDY "Enable clang tidy" ON) | ||
| else() | ||
| option(ENABLE_CLANG_TIDY "Enable clang tidy" ON) |
There was a problem hiding this comment.
@yiwen-wong maybe you forgot to change this :)
There was a problem hiding this comment.
:( I think I changed it but forgot to commit lol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create ENABLE_CLANG_TIDY (on by default) to allow user to specify if it is run during the build.