Default DB Fixes #907
Merged
Default DB Fixes #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuan
requested review from
simone-gaia,
fineg74,
daxhaw and
waynelwarren
and removed request for
simone-gaia and
fineg74
simone-gaia
approved these changes
Sep 3, 2021
| endif() | ||
|
|
||
| add_custom_command( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
gaiatandprocess_schemafor the default database.For default db,
gaiatshould not generate the::[db_name]as part of direct access class namespaces.CMake function does not accept an empty string as argument. Even if
DATABASE_NAME ""is used as named argument, it will still be treated as undefined per CMake usage. We changedprocess_schemato use default DB whenDATABASE_NAMEis undefined. As a result, most places where it is used are updated to pass in the database name explicitly.