Bug fix for GAIAPLAT-1367, 1388, 1326, 1400, 1198, 1375, 794, 1235, 1390 #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fineg74
requested review from
waynelwarren,
bill-42,
daxhaw and
simone-gaia
waynelwarren
suggested changes
Sep 16, 2021
There was a problem hiding this comment.
The google tests test_queries_node.nomatch_stmt[234] are now failing because of a change in the translation of the nomatch block. I believe that the change is incorrect because it moves the block into the loop of the declarative statement it is "nomatching". It needs to remain out of the loop.
|
Note to other reviewers: I pushed some of my test enhancements into this branch. I apologized to Gregory for this, but they are legitimate changes that just don't belong together in this same PR. They are simple and minor, so left here. |
waynelwarren
approved these changes
Sep 16, 2021
daxhaw
approved these changes
Sep 21, 2021
fineg74
changed the title
# Conflicts: # production/tools/gaia_translate/src/main.cpp # production/tools/tests/gaiat/integration_test_expected_incorrect_table_name.ruleset
chuan
pushed a commit
that referenced
this pull request
Sep 23, 2021
…390 (#914) * Fix for GAIAPLAT-1274 * Fix for GAIAPLAT-1269 * Fix for GAIAPLAT-1314 * Fix an issue that led to incorrect code generation for during the hackathon * Fix for GAIAPLAT-1367 * Fix for GAIAPLAT-1388 * updated tests resulting from hackathon issues * FIX for GAIAT-1326 * Fix for GAIAT-1400 * Fix for GAIAPLAT-1198 * [WLW] adjusted ruleset to test GAIAPLAT-1198 * added tests to confirm bug fixes for -1298 and -1251 * Fix for GAIAPLAT-1375 * Fix for GAIAPLAT-794 * Fix for GAIAPLAT-1235 * Fix for GAIAPLAT-1390 Co-authored-by: Wayne Warren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.