Add check to disallow field in on_insert() #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxhaw
reviewed
Sep 17, 2021
daxhaw
reviewed
Sep 17, 2021
| @@ -9591,6 +9591,8 @@ def err_multi_anchor_tables : Error< | |||
| "A rule may not specify multiple tables or active fields from different tables " | |||
| "in 'on_' attributes (on_insert, on_change, or on_update). " | |||
| "Ensure that all your active field references belong to the same table.">; | |||
| def err_illegal_field_reference : Error< | |||
There was a problem hiding this comment.
nit: I would strike the name from the message. I.e. A field may not be referenced in 'on_insert'. The 'on_insert' attribute only accepts a table.
daxhaw
reviewed
Sep 17, 2021
| @@ -2477,6 +2477,12 @@ class rule_match_handler_t : public MatchFinder::MatchCallback | |||
| string table, field, tag; | |||
| if (parse_attribute(table_iterator, table, field, tag)) | |||
| { | |||
| if (!field.empty()) | |||
| { | |||
| gaiat::diag().emit(diag::err_illegal_field_reference); | |||
There was a problem hiding this comment.
I think the source location here is probably good enough.
There was a problem hiding this comment.
I'll leave it that way.
| @@ -9591,6 +9591,8 @@ def err_multi_anchor_tables : Error< | |||
| "A rule may not specify multiple tables or active fields from different tables " | |||
| "in 'on_' attributes (on_insert, on_change, or on_update). " | |||
| "Ensure that all your active field references belong to the same table.">; | |||
| def err_illegal_field_reference : Error< | |||
| "A field may not be referenced in the 'on_insert' statement. The 'on_insert' attribute only accepts a table.">; | |||
There was a problem hiding this comment.
Is on_insert a statement or an attribute? It's confusing to call it differently in the same error message. Maybe instead of statement or attribute, we should call it "clause"?
chuan
pushed a commit
that referenced
this pull request
Sep 23, 2021
* Add check to disallow field in on_insert() * revert some clang-tidy changes to avoid diffs * another attempt to fix formatting issues * removed unnecessary line of code * responding to PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of
on_insert(tablename.fieldname), we are now disallowing thefieldname, as requested in GAIAPLAT-1396.This emits an error message like:
If the caret should appear below
max_temp, I can follow up with another commit for this.Note that formatting changes in
main.cppare a persistent problem until the file has stable formatting. The changes are an attempt to do that.