[GAIAPLAT-1245] Incrementing with tagged property produces a compile error #955
Conversation
simone-gaia
requested review from
waynelwarren,
LaurentiuCristofor,
daxhaw,
fineg74 and
JackAtGaia
| @@ -1382,8 +1381,7 @@ SourceRange get_expression_source_range(ASTContext* context, const Stmt& node, c | |||
| else if (const auto* expression = node_parents_iterator.get<GaiaForStmt>()) | |||
| { | |||
| SourceRange for_condition_source_range = SourceRange(expression->getLParenLoc().getLocWithOffset(1), expression->getRParenLoc().getLocWithOffset(-1)); | |||
| if (is_range_contained_in_another_range(for_condition_source_range, return_value) || | |||
| is_range_contained_in_another_range(return_value, for_condition_source_range)) | |||
| if (is_range_contained_in_another_range(for_condition_source_range, return_value) || is_range_contained_in_another_range(return_value, for_condition_source_range)) | |||
There was a problem hiding this comment.
This is already fixed in another PR.
There was a problem hiding this comment.
Yes, I thought this looked familiar.
| @@ -631,6 +631,12 @@ ruleset test_insert_delete_2 | |||
| { | |||
| grade = c_grade_d + c_grade_plus; | |||
| } | |||
|
|
|||
| on_update(s:student) | |||
| { | |||
There was a problem hiding this comment.
and maybe just an unqualified total_hours++ as well to round out the test case.
| anyOf( | ||
| hasOperatorName("++"), | ||
| hasOperatorName("--")), | ||
| hasUnaryOperand( |
There was a problem hiding this comment.
I guess this is AST101 for me. Why was the above matcher not sufficient? I.e., how did you know it needed to be this to fix the issue with the Tag. I'm trying to understand why T.field++ was not recognized as something Gaia had to act on but table.field++ or field++ worked just fine.
There was a problem hiding this comment.
Well actually it was not matching table.field++ either. Once I realized that it was trivial to understand that the matcher needs to be the same as the fieldSet (line above).
As of why it did't match, I guess the reason is that memberExpr(member(hasAttr(attr::GaiaFieldLValue looks for the attr::GaiaFieldLValue on the member side field instead of the other table side table.
…into rondelli-gaiat-plusplus
No description provided.