Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test resolution annotations, enabled tests #961

Merged
merged 3 commits into from
Sep 29, 2021

Conversation

waynelwarren
Copy link
Contributor

Test annotations to cross-reference with Jira. Enabled tags_test09.ruleset as well.


#include "tags_test.h"

class sensor_t {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The { should be on a separate line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it.

@waynelwarren
Copy link
Contributor Author

@simone-gaia doesn't consider GAIAPLAT-1178 done, so I have changed the annotations on that one and added an additional test for it.

on_update(i:incubator)
{
int i = 0;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link
Contributor

@LaurentiuCristofor LaurentiuCristofor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good, but there's an indentation issue in one of the new tests.

@waynelwarren waynelwarren merged commit aef6537 into master Sep 29, 2021
@waynelwarren waynelwarren deleted the wayne/test-annotations branch September 29, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants