Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AMR Swarm DDL to integration tests #970

Merged
merged 5 commits into from
Oct 6, 2021

Conversation

waynelwarren
Copy link
Contributor

@waynelwarren waynelwarren commented Oct 2, 2021

This is the amr_swarm.ddl plus integration tests that invoke rules used in the AMR demo.

The AMR ruleset is included, together with procedural code that is needed to satisfy the calls made by the rules.

There is no need to synchronize these files with the original AMR demo files. These modified versions can be used to exercise the DDL, which is the most complex of the integration tests, and use the combination of declarative and EDC references.

Note that amr_swarm.ddl is about 1300 lines long and takes a long time to translate.

Copy link
Contributor

@simone-gaia simone-gaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@@ -0,0 +1,541 @@
---------------------------------------------
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, what version of the ddl is this? Is the latest created by @JackAtGaia?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's from a week ago on jack/hack.

@waynelwarren waynelwarren marked this pull request as ready for review October 5, 2021 14:19
@waynelwarren waynelwarren merged commit d4ab22b into master Oct 6, 2021
@waynelwarren waynelwarren deleted the wayne/add-amr-swarm-tests branch October 6, 2021 01:37
@senderista
Copy link
Contributor

We need to move this out of the regular build and under a CI flag. The compile times in debug builds are wrecking my workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants