Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update SpriteAtlas loading logic #1067

Merged
merged 13 commits into from
Apr 7, 2023

Conversation

cptbtptpbcptdtptp
Copy link
Collaborator

@cptbtptpbcptdtptp cptbtptpbcptdtptp commented Sep 21, 2022

  • When loading Sprites, get them from the SpriteAtlas first.
  • Discard _assetID attribute.
  • Add export options.(mipmap, wrapModeV, wrapModeU, filterMode, anisoLevel)

@cptbtptpbcptdtptp cptbtptpbcptdtptp added enhancement New feature or request 2D labels Sep 21, 2022
@cptbtptpbcptdtptp cptbtptpbcptdtptp added this to the 0.9 milestone Sep 21, 2022
@cptbtptpbcptdtptp cptbtptpbcptdtptp self-assigned this Sep 21, 2022
Copy link
Member

@singlecoder singlecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@GuoLei1990 GuoLei1990 changed the base branch from dev/0.9 to dev/1.0 November 8, 2022 04:14
@GuoLei1990 GuoLei1990 modified the milestones: 0.9, 1.0 Nov 14, 2022
@GuoLei1990 GuoLei1990 added low priority Low priority issue sprite 2D Sprite medium priority Medium priority issue and removed 2D low priority Low priority issue labels Nov 14, 2022
@GuoLei1990 GuoLei1990 mentioned this pull request Nov 15, 2022
37 tasks
@cptbtptpbcptdtptp cptbtptpbcptdtptp changed the base branch from dev/1.0 to main April 2, 2023 13:54
@cptbtptpbcptdtptp cptbtptpbcptdtptp changed the title feat: update SpriteAtlas loading logic Fix update SpriteAtlas loading logic Apr 3, 2023
@cptbtptpbcptdtptp
Copy link
Collaborator Author

Test code.

/**
 * @title Scene Basic
 * @category Basic
 */
// Import Modules
import { AssetType, Scene, WebGLEngine } from "oasis-engine";
const engine = new WebGLEngine("canvas");

engine.resourceManager
  .load<Scene>({
    type: AssetType.Scene,
    url: "https://mmtcdp.stable.alipay.net/oasis_be/afts/file/A*75IDSaeFEFkAAAAAAAAAAAAADt53AQ/scene.json",
  })
  .then((scene: Scene) => {
    engine.canvas.resizeByClientSize();
    engine.sceneManager.activeScene = scene;
    // Run Engine
    engine.run();
  });

@GuoLei1990 GuoLei1990 added the ignore for release ignore for release label Apr 7, 2023
@GuoLei1990 GuoLei1990 merged commit 474446d into galacean:main Apr 7, 2023
GuoLei1990 added a commit that referenced this pull request Apr 10, 2023
* main:
  build: update helper error (#1459)
  Fix `SpriteLoader` and `SpriteAtlasLoader`  import error (#1457)
  Fix and optimization `SpriteAtlas` loading logic (#1067)
  build: rename General package
GuoLei1990 added a commit to GuoLei1990/galacean-engine that referenced this pull request Apr 12, 2023
…rocedural

* commit '263940fccd3bdc6372344529bc4b13285b3b1f66':
  Refactor skybox material (galacean#1430)
  `CharacterController` support transform `scale` and shape `position` (galacean#1363)
  build: update helper error (galacean#1459)
  Fix `SpriteLoader` and `SpriteAtlasLoader`  import error (galacean#1457)
  Fix and optimization `SpriteAtlas` loading logic (galacean#1067)
  build: rename General package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ignore for release ignore for release medium priority Medium priority issue sprite 2D Sprite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants