Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix engine destroy bug #1198

Merged
merged 3 commits into from
Nov 17, 2022
Merged

Conversation

GuoLei1990
Copy link
Member

@GuoLei1990 GuoLei1990 commented Nov 17, 2022

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Fix destroy bug when engine not run loop( pause )
  • Fix call another script destroy in script onDestroy() by double array

@GuoLei1990 GuoLei1990 added the bug Something isn't working label Nov 17, 2022
@GuoLei1990 GuoLei1990 self-assigned this Nov 17, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 42.68% // Head: 44.48% // Increases project coverage by +1.79% 🎉

Coverage data is based on head (2463b42) compared to base (c7c5a0b).
Patch coverage: 92.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1198      +/-   ##
==========================================
+ Coverage   42.68%   44.48%   +1.79%     
==========================================
  Files         347      347              
  Lines       18314    18324      +10     
  Branches     2537     2538       +1     
==========================================
+ Hits         7818     8152     +334     
+ Misses       9890     9520     -370     
- Partials      606      652      +46     
Impacted Files Coverage Δ
packages/core/src/Engine.ts 85.13% <85.71%> (+14.30%) ⬆️
packages/core/src/ComponentsManager.ts 73.68% <100.00%> (+9.34%) ⬆️
packages/core/src/Script.ts 88.05% <100.00%> (+4.47%) ⬆️
packages/math/src/Color.ts 64.70% <0.00%> (-1.69%) ⬇️
packages/core/src/mesh/ModelMesh.ts 89.63% <0.00%> (+0.38%) ⬆️
packages/core/src/shadow/ShadowUtils.ts 9.75% <0.00%> (+1.21%) ⬆️
packages/core/src/Scene.ts 70.58% <0.00%> (+1.30%) ⬆️
packages/math/src/Vector2.ts 81.81% <0.00%> (+1.51%) ⬆️
packages/core/src/Transform.ts 55.15% <0.00%> (+1.51%) ⬆️
packages/rhi-webgl/src/GLTexture.ts 44.18% <0.00%> (+1.86%) ⬆️
... and 28 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@cptbtptpbcptdtptp cptbtptpbcptdtptp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@GuoLei1990 GuoLei1990 merged commit 2c66858 into galacean:main Nov 17, 2022
@GuoLei1990 GuoLei1990 linked an issue Nov 21, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak problem
3 participants