Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename asset type of engine asset #1416

Merged
merged 5 commits into from
Mar 22, 2023

Conversation

gz65555
Copy link
Collaborator

@gz65555 gz65555 commented Mar 17, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@gz65555 gz65555 changed the base branch from main to dev/1.0 March 17, 2023 05:48
@gz65555 gz65555 requested a review from GuoLei1990 March 17, 2023 05:48
@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (344de41) 49.24% compared to head (e561392) 49.23%.

❗ Current head e561392 differs from pull request most recent head 71e2428. Consider uploading reports for the commit 71e2428 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/1.0    #1416      +/-   ##
===========================================
- Coverage    49.24%   49.23%   -0.02%     
===========================================
  Files          362      362              
  Lines        18377    18377              
  Branches      2636     2636              
===========================================
- Hits          9049     9047       -2     
  Misses        8398     8398              
- Partials       930      932       +2     
Impacted Files Coverage Δ
packages/core/src/asset/AssetType.ts 100.00% <ø> (ø)
packages/loader/src/GLTFLoader.ts 66.66% <ø> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@GuoLei1990 GuoLei1990 added the resource Resource-related functions label Mar 17, 2023
@GuoLei1990 GuoLei1990 added this to the 1.0 milestone Mar 17, 2023
@gz65555 gz65555 added the breaking breaking change label Mar 21, 2023
@GuoLei1990 GuoLei1990 requested a review from zhuxudong March 22, 2023 05:52
Copy link
Member

@zhuxudong zhuxudong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zhuxudong
Copy link
Member

记得游乐场也改一下😄

@GuoLei1990 GuoLei1990 added the enhancement New feature or request label Mar 22, 2023
@GuoLei1990 GuoLei1990 merged commit 9c7fd87 into galacean:dev/1.0 Mar 22, 2023
@GuoLei1990 GuoLei1990 mentioned this pull request May 18, 2023
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking breaking change enhancement New feature or request resource Resource-related functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants