Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix glTF animation error #2014

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Fix glTF animation error #2014

merged 2 commits into from
Feb 27, 2024

Conversation

gz65555
Copy link
Collaborator

@gz65555 gz65555 commented Feb 27, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@gz65555 gz65555 changed the base branch from main to dev/1.2 February 27, 2024 11:49
zhuxudong
zhuxudong approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@zhuxudong zhuxudong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@GuoLei1990 GuoLei1990 merged commit 7ac7d5c into galacean:dev/1.2 Feb 27, 2024
5 of 6 checks passed
@GuoLei1990 GuoLei1990 added bug Something isn't working animation Built-in animation system related functions glTF labels Feb 27, 2024
@GuoLei1990 GuoLei1990 changed the title Fix animation error Fix glTF animation error Feb 27, 2024
GuoLei1990 added a commit to GuoLei1990/galacean-engine that referenced this pull request Feb 28, 2024
@GuoLei1990
Merge branch 'dev/1.2' into pr/camera-opaque-texture
04fcbd8 
* dev/1.2:
  Fix animation error (galacean#2014)
  Fix camera renderTarget flip error (galacean#1997)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuoLei1990 GuoLei1990 GuoLei1990 approved these changes

@zhuxudong zhuxudong zhuxudong approved these changes

@luzhuang luzhuang Awaiting requested review from luzhuang

Assignees
No one assigned
Labels
animation Built-in animation system related functions bug Something isn't working glTF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gz65555 @GuoLei1990 @zhuxudong