Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Particle start size support curve mode #2568
Particle start size support curve mode #2568
Changes from all commits
cb8eb48
78ed3dd
a986c96
7898e78
e483287
daa9912
bf6753e
4eb6b1d
0b0a16d
0ff8036
11b0228
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 745 in packages/core/src/particle/ParticleGenerator.ts
packages/core/src/particle/ParticleGenerator.ts#L743-L745
Check warning on line 814 in packages/core/src/particle/ParticleGenerator.ts
packages/core/src/particle/ParticleGenerator.ts#L814
Check warning on line 817 in packages/core/src/particle/ParticleGenerator.ts
packages/core/src/particle/ParticleGenerator.ts#L817
Check warning on line 179 in packages/core/src/particle/modules/ParticleCompositeCurve.ts
packages/core/src/particle/modules/ParticleCompositeCurve.ts#L179
Check warning on line 182 in packages/core/src/particle/modules/ParticleCompositeCurve.ts
packages/core/src/particle/modules/ParticleCompositeCurve.ts#L181-L182
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we check if the keys array is empty here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect assertion for key addition test.
The assertion is checking for
curve.keys[0].value
to equal0.3
, but this doesn't match the expected behavior after adding a new key with value0.4
. The new key should either replace the existing key at index 0 or be sorted into the proper position, depending on the implementation.📝 Committable suggestion
🧰 Tools
🪛 ESLint
[error] 59-59: Replace
+··
with···+
(prettier/prettier)
[error] 60-60: Replace
+··
with···+
(prettier/prettier)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect assertions after key removal.
After removing the key at index 0, you're expecting the remaining key to have time 0.0 and value 0.4, but based on the initial setup and removal operations, I'd expect the remaining key to have time 0.0 (from the newly added key) and value 0.4.
Let's verify the expected behavior:
📝 Committable suggestion
🧰 Tools
🪛 ESLint
[error] 68-68: Replace
+··
with···+
(prettier/prettier)
[error] 69-69: Replace
+··
with···+
(prettier/prettier)