Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wasm repo importable #1

Closed
wants to merge 5 commits into from
Closed

Wasm repo importable #1

wants to merge 5 commits into from

Conversation

webplusai
Copy link

No description provided.

Copy link
Contributor

@enthusiastmartin enthusiastmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. that's why it probably did not work for @jak-pan at the very beginining when he was not able to import for some reason.

Anyway -just for info - this is going to be refactored soon and among other changes - it will be also renamed ( the hack_ prefix will be removed ).

@enthusiastmartin enthusiastmartin self-requested a review March 9, 2021 12:54
@enthusiastmartin enthusiastmartin dismissed their stale review March 9, 2021 12:54

see comment about auto generation.

@enthusiastmartin
Copy link
Contributor

well, actually. this is all generated when i run wasm build.

So now, when i make changes and rerun - it will be back to the original implementation.

Any specific reason why it has to be done in this way ? ( i mean, changes to the js files ).

@jak-pan
Copy link
Contributor

jak-pan commented Mar 9, 2021

Actually it was not this issue. It was much dumber. I tried to import wasm in nodejs like you do it in javascript.

@jak-pan
Copy link
Contributor

jak-pan commented Mar 9, 2021

But yes. We should probably remove the demo part and generate correctly. I'm not sure too why we need the changes in js as it should work in webpack like presented. Just needs a config I guess.

@jak-pan
Copy link
Contributor

jak-pan commented Mar 16, 2021

the #2 is the culprit.

@webplusai webplusai closed this May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants