Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null handling and optional values for integers, floats, and text params. #10703

Merged
merged 1 commit into from
Nov 13, 2020

Conversation

jmchilton
Copy link
Member

No description provided.

@dannon
Copy link
Member

dannon commented Nov 12, 2020

@jmchilton Will this address the problem I attempted to start poking at in #9484? That'd be awesome if so. (root issue was #8375)

@galaxybot galaxybot added this to the 21.01 milestone Nov 12, 2020
@jmchilton
Copy link
Member Author

@dannon I don't think this would fix that, but I think tightening up our testing around types moves us in that direction and the new value_json inputs and outputs could definitely help try to recreate that issue in the tool form (it might just be workflow thing though). I did rebase to add this test case:

+        <test>
+            <param name="text_input" value_json="&quot;null&quot;" />
+            <output name="text_out" value_json="&quot;null&quot;" />
+        </test>

... thinking it was going to ruin my day, but it did in fact work - which was utterly shocking.

@dannon
Copy link
Member

dannon commented Nov 12, 2020

@jmchilton Thanks! I figured it might be a long shot; I don't think I've ever reproduced that in the regular tool form -- it seemed to be related to double-decoding the payload the workflow endpoint receives.

@mvdbeek
Copy link
Member

mvdbeek commented Nov 12, 2020

That does look related:

galaxy.tool_util.verify.interactor.JobOutputsError: Output text_out: Expected object () does not match actual object (__oc____sq__src__sq__: __sq__hda__sq__, __sq__id__sq__: __sq__b114bfef23b8f61b__sq____cc__)

@jmchilton
Copy link
Member Author

Those work locally, it must be an issue with how we are using postgres JSON 😢

@mvdbeek mvdbeek merged commit f7bba74 into galaxyproject:dev Nov 13, 2020
mvdbeek added a commit to mvdbeek/galaxy that referenced this pull request Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants