Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Disable storage dashboard button for anon users #18922

Merged

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Oct 2, 2024

Should largely avoid
https://sentry.galaxyproject.org/share/issue/79354f243bd44cbf833255e27d6dd8fa/:

Error: API authentication required for this request
  at rethrowSimple(webpack://@galaxyproject/galaxy-client/./src/utils/simple-error.ts:24:11)
  at <anonymous>(webpack://@galaxyproject/galaxy-client/./src/api/schema/fetcher.ts:19:9)
  at Generator.throw(<anonymous>)
  at rejected(webpack://@galaxyproject/galaxy-client/./src/api/schema/fetcher.ts:5:64)

Note that the stack trace isn't as informative as the url ( https://usegalaxy.org/storage/history/<history_id>) and referrer.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Should largely avoid
https://sentry.galaxyproject.org/share/issue/79354f243bd44cbf833255e27d6dd8fa/:
```
Error: API authentication required for this request
  at rethrowSimple(webpack://@galaxyproject/galaxy-client/./src/utils/simple-error.ts:24:11)
  at <anonymous>(webpack://@galaxyproject/galaxy-client/./src/api/schema/fetcher.ts:19:9)
  at Generator.throw(<anonymous>)
  at rejected(webpack://@galaxyproject/galaxy-client/./src/api/schema/fetcher.ts:5:64)
```
Note that the stack trace isn't as informative as the url (
https://usegalaxy.org/storage/history/<history_id>) and referrer.
@github-actions github-actions bot added this to the 24.1 milestone Oct 2, 2024
Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Thank you!

@davelopez davelopez merged commit c629bdd into galaxyproject:release_24.1 Oct 2, 2024
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants