Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove transaction helper #19407

Merged
merged 39 commits into from
Jan 24, 2025
Merged

Remove transaction helper #19407

merged 39 commits into from
Jan 24, 2025
+658 −1,433

Conversation

jdavcs
Copy link
Member

@jdavcs jdavcs commented Jan 14, 2025 •
edited
Loading

Follow-up to #19388

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jdavcs jdavcs added kind/refactoring cleanup or refactoring of existing code, no functional changes area/testing area/database Galaxy's database or data access layer labels Jan 14, 2025
@jdavcs jdavcs added this to the 25.0 milestone Jan 14, 2025
@jdavcs jdavcs force-pushed the dev_remove_transaction_helper branch from a35ec8d to 86d046e Compare January 14, 2025 19:35
@jdavcs jdavcs changed the title [WIP] Remove transaction helper Remove transaction helper Jan 14, 2025
@jdavcs jdavcs marked this pull request as ready for review January 14, 2025 23:14
@jdavcs jdavcs requested a review from a team January 15, 2025 14:44
@jdavcs jdavcs mentioned this pull request Jan 15, 2025
Closed
28 tasks
jdavcs and others added 20 commits January 23, 2025 11:39
@jdavcs
Remove transaction helper from test.unit.job_execution
f0de72b
@jdavcs
Remove transaction helper from test.unit.workflows
f39702b
@jdavcs
Remove transaction helper from test.unit.data
6f47682
@jdavcs
Remove transaction helper from test.unit.app.jobs
a26cd0f
@jdavcs
Remove transaction helper from test.unit.app.managers
1ce27e3
@jdavcs
Remove transaction helper from test.unit.app.tools
dee8804 
Note: app.model.context.current == app.model.context. The `current` attr
may have been a very legacy attribute still silently supported.
@jdavcs
Remove transaction helper from test.integration
62155b9
@jdavcs
Remove transaction helper from scripts
896d084
@jdavcs @nsoranzo
Fix typo
7886de0 
Co-authored-by: Nicola Soranzo <[email protected]>
@jdavcs
Remove transaction helper from galaxy.security
79f44a2
@jdavcs
Remove transaction helper from galaxy.model
6575666
@jdavcs
Remove transaction helper from galaxy.tools
dd221af
@jdavcs
Remove transaction helper from galaxy.job_execution
cf4f7f9
@jdavcs
Remove transaction helper from galaxy.managers
87bb447
@jdavcs
Remove transaction helper from galaxy.quota
74e4c97
@jdavcs
Remove transaction helper from galaxy.celery
bc13d78
@jdavcs
Remove transaction helper from galaxy.app_unittest_utils
6125c2e
@jdavcs
Remove transaction helper from galaxy.work
8af74a8
@jdavcs
Remove transaction helper from galaxy.authnz
e65045e
@jdavcs
Remove transaction helper from galaxy.workflow
7275332
jdavcs added 19 commits January 23, 2025 11:39
@jdavcs
Remove transaction helper from galaxy.actions
85b9697
@jdavcs
Remove transaction helper from galaxy.jobs
b8fe28d
@jdavcs
Remove transaction helper from galaxy.web_stack
70aa1d6
@jdavcs
Remove transaction helper from galaxy.webapps.base
2f60482
@jdavcs
Remove transaction helper from galaxy.webapps.galaxy.api
226e00d
@jdavcs
Remove transaction helper from galaxy.webapps.galaxy.services
c995c36
@jdavcs
Remove transaction helper from galaxy.webapps.galaxy.controllers
17ebf87
@jdavcs
Remove transaction helper from galaxy.tool_shed
5b79724
@jdavcs
Remove transaction helper from galaxy_test
f279c2e
@jdavcs
Remove transaction helper from tool_shed.webapp.security
9cc45fc
@jdavcs
Remove transaction helper from tool_shed.webapp.api2
4da662b
@jdavcs
Remove transaction helper from tool_shed.webapp.util
7b1a9aa
@jdavcs
Remove transaction helper from tool_shed.webapp.api
1b31616
@jdavcs
Remove transaction helper from tool_shed.webapp.controllers
cee6daa
@jdavcs
Remove transaction helper from tool_shed.managers
416bb33
@jdavcs
Remove transaction helper from tool_shed.metadata
0ca0c3b
@jdavcs
Remove transaction helper from tool_shed.util
c060806
@jdavcs
Remove transaction helper from test/unit.test_galaxy_transactions
ef1aa62
@jdavcs
Remove transaction helper
1bd861a
@jdavcs jdavcs force-pushed the dev_remove_transaction_helper branch from 46163c9 to 1bd861a Compare January 23, 2025 16:44
davelopez
davelopez approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the meticulous work!
Looks good to me. I've rerun one of the ToolShed tests that failed just in case, but all the others are the usual suspects failing in other PRs.

@jdavcs jdavcs merged commit 43304d5 into galaxyproject:dev Jan 24, 2025
52 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsoranzo nsoranzo nsoranzo left review comments

@davelopez davelopez davelopez approved these changes

Assignees
No one assigned
Labels
area/database Galaxy's database or data access layer area/testing kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Milestone
25.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jdavcs @nsoranzo @davelopez