Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong id in test_combined_mapping_and_subcollection_mapping #19481

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Jan 29, 2025

We weren't actually testing what we thought we did here ...

Just noticed this while adding another test in that file. May save some debugging time in the future.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

We weren't actually testing what we thought we did here ...
@github-actions github-actions bot added this to the 25.0 milestone Jan 29, 2025
@mvdbeek mvdbeek requested a review from a team January 30, 2025 15:07
@mvdbeek
Copy link
Member Author

mvdbeek commented Jan 30, 2025

test failures unrelated

@mvdbeek mvdbeek merged commit dd8f409 into galaxyproject:dev Jan 30, 2025
53 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants