Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add py34-first_startup to Travis and default tox tests #6325

Merged
merged 6 commits into from
Jun 13, 2018

Conversation

nsoranzo
Copy link
Member

Also:

  • modify scripts/check_python.py to allow Python 3 if inside a virtualenv (printing a warning on stderr).
  • some Python3 Unicode/binary fixes

Builds on top of #6324 .

xref. #1715

nsoranzo and others added 6 commits June 13, 2018 00:32
Minimum secret key length for Blowfish was increased from 4 to 5 bytes.

First argument to Blowfish.new() must be a bytestring, and the `mode`
argument is no more optional.

Remove unused `encode_id` function from `scripts/api/common.py` .

Documentation updated, then rebuilt with `make config-rebuild` .
Because Galaxy under Python3 would fail otherwise.
Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's really awesome!

@jmchilton jmchilton merged commit f8bc065 into galaxyproject:dev Jun 13, 2018
@jmchilton
Copy link
Member

Amazing, thanks!

@nsoranzo nsoranzo added the area/python3 Specific to Python 3 label Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants