Support ledger-produced signature #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robinnnnn
reviewed
Sep 23, 2021
server/auth.go
Outdated
| v := sig[64] | ||
| // Ledger-produced signatures have v = 0 or 1 | ||
| if v == 0 || v == 1 { | ||
| v = v + 27 |
There was a problem hiding this comment.
should be sig[64] += 27, to update the actual value at that index (instead of just the variable v)
Robinnnnn
reviewed
Sep 23, 2021
| if v == 0 || v == 1 { | ||
| v = v + 27 | ||
| } | ||
| if v != 27 && v != 28 { | ||
| return false, errors.New("invalid signature (V is not 27 or 28)") | ||
| } | ||
| sig[64] -= 27 |
There was a problem hiding this comment.
lol weird that we subtract it later
There was a problem hiding this comment.
so it ends up being 0 or 1 anyway 🙃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ledger-produced signatures have v = 0 or 1, meaning they fail the existing signature validation which expects v to be 27 or 28.
Manually making an exception to allow v to be 0 or 1 seems to be an accepted solution for now.
The issue is documented in this Github Issue
More info: https://ethereum.stackexchange.com/questions/103307/cannot-verifiy-a-signature-produced-by-ledger-in-solidity-using-ecrecover