Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(heading): initially follow theme's margin if OceanWP is used #3349

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Arukuen
Copy link
Contributor

@Arukuen Arukuen commented Oct 9, 2024

fixes #3259

Copy link

github-actions bot commented Oct 9, 2024

🤖 Pull request artifacts

file commit
pr3349-stackable-3349-merge.zip b20abc4

github-actions bot added a commit that referenced this pull request Oct 9, 2024
Copy link
Contributor

@bfintal bfintal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the issue is with OceanWP only, it would be better to have a fix that would be applicable only with OceanWP and only targets the issue. Adjusting all blocks for all scenarios would pose more issues. Also, we have default margins for our blocks, this removes them

github-actions bot added a commit that referenced this pull request Feb 10, 2025
github-actions bot added a commit that referenced this pull request Feb 10, 2025
@Arukuen Arukuen changed the title fix(heading): heading v3 with less aggresive non use of theme margins fix(heading): initially follow theme's margin if OceanWP is used Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OceanWP] Stackable blocks added to Posts are already aligned as Full Width
2 participants