null check banner.h (prebid#1142)

gamoshi · Dec 12, 2019 · dd912fc · dd912fc
1 parent eee0644
commit dd912fc
Show file tree

Hide file tree

Showing 2 changed files with 48 additions and 0 deletions.
diff --git a/adapters/audienceNetwork/audienceNetworktest/supplemental/missing-banner-height.json b/adapters/audienceNetwork/audienceNetworktest/supplemental/missing-banner-height.json
@@ -0,0 +1,42 @@
+{
+  "mockBidRequest": {
+    "id": "test-req-id",
+    "imp": [
+      {
+        "id": "1",
+        "banner": {
+            "format": [
+                {
+                    "w": 640
+                }
+            ],
+            "w": 640
+        },
+        "ext": {
+          "bidder": {
+              "placementId": "plmt1",
+              "publisherId": "pub1"
+          }
+        }
+      }
+    ],
+    "site": {
+      "domain": "prebid.org",
+      "page": "prebid.org"
+    },
+    "device": {
+      "ip": "152.193.6.74"
+    },
+    "user": {
+      "id": "db089de9-a62e-4861-a881-0ff15e052516",
+      "buyeruid": "v4_bidder_token"
+    },
+    "tmax": 500
+  },
+  "expectedMakeRequestsErrors": [
+      {
+          "value": "imp #1: banner height required",
+          "comparison": "literal"
+      }
+  ]
+}
diff --git a/adapters/audienceNetwork/facebook.go b/adapters/audienceNetwork/facebook.go
@@ -183,6 +183,12 @@ func (this *FacebookAdapter) modifyImp(out *openrtb.Imp) error {
 			return nil
 		}
 
+		if out.Banner.H == nil {
+			return &errortypes.BadInput{
+				Message: fmt.Sprintf("imp #%s: banner height required", out.ID),
+			}
+		}
+
 		if _, ok := supportedBannerHeights[*out.Banner.H]; !ok {
 			return &errortypes.BadInput{
 				Message: fmt.Sprintf("imp #%s: only banner heights 50 and 250 are supported", out.ID),