Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.9.0 breaks responsiveness when multiple items are shown. #361

Open
webpro-solutions opened this issue Dec 27, 2018 · 4 comments
Open

2.9.0 breaks responsiveness when multiple items are shown. #361

webpro-solutions opened this issue Dec 27, 2018 · 4 comments

Comments

@webpro-solutions
Copy link

Issue description: I recently updated from 2.8.8 to 2.9.0 and now our responsive sliders with multiple items showing with lazy loading (which worked in 2.8.8) are having issues. When it hits the breakpoint, it adjusts to the proper size, however, it is leaving empty spaces where images should be (lazy loaded images that haven't loaded and don't ever load). There was even some overlapping of images (the dynamic positioning was off).

Demo link/slider setting: I don't have a public demo but here are the settings being used:
const theMultiCarousel = tns({
items: 1,
responsive: {
480: {
items: 2
},
768: {
items: 3
},
991: {
items: 4
}
},
container: this.targetElement,
nav: false,
slideBy: '1',
gutter: 15,
autoplay: true,
controlsText: ['', ''],
autoplayButtonOutput: false,
mouseDrag: true,
lazyload: true
});

Tiny-slider version: 2.9.0 and 2.9.1
Browser name && version: Chrome: Version 71.0.3578.98 | Firefox: 64.0 | Safari: 12.0.2 | IE 11
OS name && version: MacOS High Sierra V 10.13.6

@torsteinringnes
Copy link

Can confirm, I have the exact same issue.

@scsskid
Copy link

scsskid commented Jan 20, 2019

confirmed, rolled back, 2.8.8 works, didnt test 2.8.9 (if released)

@fatcrobat
Copy link

Same here, rolled back to 2.8.8.

scottleblang added a commit to scottleblang/tiny-slider that referenced this issue Mar 5, 2019
Changed '||' to '&&' to fix issue with responsiveness when page is resized below a breakpoint; Bug relating to ganlanyuan#361
@scottleblang
Copy link
Contributor

Created a pull request for this issue. Changing line 1426 in src/tiny-slider.js from:
if (itemsChanged || !carousel) { updateGallerySlidePositions(); }
to
if (itemsChanged && !carousel) { updateGallerySlidePositions(); }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants