Add configure option to select GC; introduce USE_GASMAN macro #2299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, this is not very useful, as one essentially can only select GASMAN for GAP and Boehm GC for HPC-GAP. However, in the future Boehm GC may become selectable for GAP, and other garbage collectors may become available.
This gives us finer control over which feature to enable for which memory manager, which will make it easier to potentially use Boehm GC in GAP, or other GCs in either GAP or HPC-GAP.
fingolfin
added
topic: build system
topic: kernel
release notes: not needed
ChrisJefferson
approved these changes
Mar 25, 2018
|
This looks reasonable. I haven't checked the resulting GAP (boehm in non-HPC GAP) works. |
|
Actually, right now this does not allow selecting Boehm GC in plain GAP ! It just lays the ground work for that -- I have not attempted to even compile GAP in that mode so far. |
Codecov Report
@@ Coverage Diff @@
## master #2299 +/- ##
==========================================
+ Coverage 71.81% 71.88% +0.06%
==========================================
Files 479 479
Lines 251663 252258 +595
==========================================
+ Hits 180729 181326 +597
+ Misses 70934 70932 -2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also rename
BOEHM_GCtoUSE_BOEHM_GC, for uniformity. Also change the code to useUSE_GASMANandUSE_BOEHM_GCmore consistently; e.g. don't assume that HPC-GAP uses Boehm and non-HPC-GAP uses GASMAN.This is part of #2092 (I wrote this code for @rbehrends but since that work currently doesn't seem to go anywhere, I think it's best to merge this now, instead of letting it bitrot).
Resolves #1470