-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch Travis to use Ubuntu 16.04 "xenial", and other CI tweaks #2759
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2759 +/- ##
===========================================
+ Coverage 83.81% 85.24% +1.43%
===========================================
Files 683 110 -573
Lines 345977 56994 -288983
===========================================
- Hits 289967 48586 -241381
+ Misses 56010 8408 -47602
|
Not sure whether it makes sense; for I spent quite a bit of time trying to debug a linker problem with |
sorry, I merged #2702 which caused a conflict with this PR... |
2bdebbe
to
0d9e01d
Compare
gcc at least 5.0 would be very useful. The list of hacks to disable packages might now be extended with Digraphs (#2768). Hope with this PR all those hacks will be gone. But test of this PR currently fail to build packages:
|
04869e3
to
30c9a3c
Compare
c4efca4
to
708875a
Compare
@fingolfin did you manage to get at least the gcc-5 of this PR working? I'd really love to have it because otherwise Semigroups can not be compiled on Travis, which severely reduces ability to identify potential problems. |
708875a
to
eaf8f28
Compare
Oh, again this
|
4979919
to
8f79ecc
Compare
8534ead
to
328cf4d
Compare
0ba6bac
to
7467cbe
Compare
This seems to be working now, at least with reduced tests. I've now cleaned up the PR, and in particular re-enabled all tests, so let's see if it still passes. |
To document the digraphs issue in more place: this happened because we added |
ci-prepare.sh already adds it
It causes problems for kernel extensions with C++ code when built using g++, which ends up inserting `atexit` calls that cause linker errors when trying to load the kernel extension/
* make etc/ci-gather-coverage.sh more verbose * output timings for configure and make * remove hack for NormalizInterface-0.9.8 * re-enable digraphs, semigroups, float * disable xgap
@@ -58,7 +61,7 @@ matrix: | |||
- libcurl4-openssl-dev:i386 # for curlInterface | |||
- libboost-dev:i386 # for NormalizInterface | |||
- libmpfr-dev:i386 # for float | |||
- libmpfi-dev:i386 # for float | |||
- libmpfi0-dev:i386 # for float |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- libmpfi0-dev:i386 # for float | |
- libmpfi0-dev:i386 # for float |
This should allow us to build semigroups and digraphs again (alas, it seems digraphs still runs into these weird atexit troubles...)