Don't automatically call attribute setters on mutable objects #3592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevelinton
added
kind: enhancement
This was referenced Jul 24, 2019
Codecov Report
@@ Coverage Diff @@
## master #3592 +/- ##
==========================================
+ Coverage 82.29% 84.55% +2.25%
==========================================
Files 648 697 +49
Lines 317517 344997 +27480
==========================================
+ Hits 261305 291697 +30392
+ Misses 56212 53300 -2912
|
stevelinton
removed
the
do not merge
stevelinton
changed the title
This was referenced Jul 29, 2019
|
There's a failing test https://travis-ci.org/gap-system/gap/jobs/565395421#L2106 |
|
@wilfwilson The test fails because of #3596 |
stevelinton
force-pushed
the
mut-attrs2
branch
from
52907f5 to
f05ebec
Compare
|
I've adjusted the test to work around #3596. I think this is now ready. |
wilfwilson
reviewed
Aug 13, 2019
doc/ref/types.xml
Outdated
| @@ -568,7 +575,8 @@ of the object <A>obj</A> is known. | |||
| <Description> | |||
| For an attribute <A>attr</A>, <C>Setter(<A>attr</A>)</C> | |||
| is called automatically when the attribute value has been | |||
| computed for the first time. | |||
| computed for an immutable object which does not already have stored | |||
| value for <A>attr</A>. | |||
There was a problem hiding this comment.
There's a missing article here, I think 'have a value stored' would make it right.
stevelinton
force-pushed
the
mut-attrs2
branch
from
f05ebec to
258df81
Compare
wilfwilson
approved these changes
Aug 14, 2019
DominikBernhardt
removed
the
release notes: to be added
DominikBernhardt
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an alternative to #3588. Instead of stopping the system setters storing in mutable objects, we stop attribute calls from calling the setter altogether in this situation.
This allows for calling the setter directly, but means that even if you have installed a custom setter, it is not called by default.
See also #1371 and #3560
Text for release notes
The values of computed Attributes will no longer be stored automatically in mutable attribute-storing
objects, since they may become out of date as the object mutates. If you wish to store such a value and know that it is safe to do so, then you can address this by calling the corresponding attribute setter directly.