Add CI job that tests with GAP.jl #5733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am happy to postpone this for a future PR, but I don't understand what the problem is: just let Pkg.jl take care of this? I.e. don't use |
pranav-joshi-iitgn
added a commit
to pranav-joshi-iitgn/gap
that referenced
this pull request
Jun 7, 2024
Add CI job that tests with GAP.jl (gap-system#5733)
fingolfin
added
release notes: not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves oscar-system/GAP.jl#994.
I think that testing with the latest GAP.jl release would be great as well, but it seems to be kind of non-trivial to find the release tag from withing the job. Thus, I would keep that for a future PR.
cc @fingolfin
Text for release notes
none