perf(git): cache git exec results #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchfriedman
force-pushed
the
cache-git-results
branch
from
55bca15 to
a5711f1
Compare
edvald
reviewed
Jul 6, 2020
garden-service/src/vcs/git.ts
Outdated
| @@ -81,10 +82,16 @@ export class GitHandler extends VcsHandler { | |||
| } | |||
|
|
|||
| async getRepoRoot(log: LogEntry, path: string) { | |||
| if (this.repoRoot) { | |||
| return this.repoRoot | |||
There was a problem hiding this comment.
This needs to be cached based on the path value, because there may be multiple repo roots, e.g. with remote sources, submodules etc
mitchfriedman
force-pushed
the
cache-git-results
branch
from
a5711f1 to
070900f
Compare
edvald
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache results of the
git exec calls.Pretty anecdotal/not-profile-driven perf improvements, but intuitively it makes sense anyways.
For example, on a project i'm working on I get over 200 of:
with > 700 git commands executing
before:
after:
What this PR does / why we need it:
Faster commands :)