feat(core): throw workflow config errors on scan #1932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now throw validation errors for invalid workflow configs immediately after scanning and adding workflow configs. Now that partially resolving workflow configs (i.e. everything except step configs, which are resolved just-in-time before they're run) has become cheap, performing this validation at scan-time warns the user of invalid workflow configs earlier in development.
edvald
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We now throw validation errors for invalid workflow configs immediately after scanning and adding workflow configs.
Now that partially resolving workflow configs (i.e. everything except step configs, which are resolved just-in-time before they're run) has become cheap, performing this validation at scan-time warns the user of invalid workflow configs earlier in development.
Which issue(s) this PR fixes:
Fixes #1931.