improvement(config): explicitly validate sub-paths when applicable #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edvald
force-pushed
the
validate-subpaths
branch
4 times, most recently
from
61a4fc9 to
72f9605
Compare
We add a `path` rule, with options to disallow absolute paths or parent paths, i.e. stepping up a directory tree, in order to ensure that some paths are sub-paths of a project or module. This required a refactor where we use a custom Joi instance across our codebase, hence the size of the change. This is done both for general hardening, and in preparation of #853 and other similar configuration options.
thsig
approved these changes
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add a
pathrule, with options to disallow absolute paths or parentpaths, i.e. stepping up a directory tree, in order to ensure that some
paths are sub-paths of a project or module.
This required a refactor where we use a custom Joi instance across our
codebase, hence the size of the change.
This is done both for general hardening, and in preparation of #853 and
other similar configuration options.