Drop the sigs.k8s.io/metrics-server dependency #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot
added
area/auto-scaling
gardener-robot-ci-1
added
needs/ok-to-test
|
I see that starting [email protected], it provides a default OpenAPIConfig. See kubernetes-sigs/custom-metrics-apiserver#110 |
ialidzhikov
force-pushed
the
enh/drop-metrics-server-dep
branch
from
0d2a6f9 to
ee3302d
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
andrerun
approved these changes
Mar 22, 2024
gardener-robot
added
the
status/closed
29 tasks
andrerun
pushed a commit
that referenced
this pull request
Mar 26, 2024
* Drop the replace for k8s.io/client-go * Drop the sigs.k8s.io/metrics-server dependency
ialidzhikov
added a commit
to ialidzhikov/gardener-custom-metrics
that referenced
this pull request
Mar 27, 2024
ialidzhikov
added a commit
to ialidzhikov/gardener-custom-metrics
that referenced
this pull request
Mar 28, 2024
ialidzhikov
added a commit
to ialidzhikov/gardener-custom-metrics
that referenced
this pull request
Mar 28, 2024
ialidzhikov
added a commit
to ialidzhikov/gardener-custom-metrics
that referenced
this pull request
Mar 31, 2024
ialidzhikov
added a commit
to ialidzhikov/gardener-custom-metrics
that referenced
this pull request
Apr 2, 2024
ialidzhikov
added a commit
to ialidzhikov/gardener-custom-metrics
that referenced
this pull request
Apr 4, 2024
ialidzhikov
added a commit
to ialidzhikov/gardener-custom-metrics
that referenced
this pull request
Apr 5, 2024
ialidzhikov
added a commit
to ialidzhikov/gardener-custom-metrics
that referenced
this pull request
Apr 5, 2024
ialidzhikov
added a commit
to ialidzhikov/gardener-custom-metrics
that referenced
this pull request
Apr 8, 2024
ialidzhikov
added a commit
that referenced
this pull request
Apr 10, 2024
…0.16` (#14) * [prerequisite] Drop the unused client field from the actuators * [prerequisite] Drop dependency injection funcs * Upgrade `k8s.io/*` to `v0.28`, `sigs.k8s.io/controller-runtime` to `v0.16` * Adapt to the breaking change in the manager.Options struct * Adapt to the breaking change how the watch is being set up * Use the upstream fake client instead of a custom fake manager * Drop unit tests for AddNewControllerToManager * Use k8s.io/utils/ptr instead of the deprecated k8s.io/utils/pointer pkg * Use the upstream fake client instead of the custom fake client * Drop the custom fake client * Drop the fake manager * Use consistent naming for the manager * Drop custom OpenAPIConfig instead of the default one from custom-metrics-apiserver See #8 (comment) * Adapt to the breaking change how the cache is restricted to object with label selectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area auto-scaling
/kind cleanup
What this PR does / why we need it:
According to my testing the
sigs.k8s.io/metrics-serveris not required for the custom-metrics-apiserver to function properly.I build an image with the changes from this PR. Then I applied the resources from the example dir to existing Seed cluster in Gardener's well know local setup. After that I queried the custom metrics with:
Which issue(s) this PR fixes:
Part of #5
Special notes for your reviewer:
N/A
Release note: