Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

Improve VPN Shoot IP forwarding solution for Calico v3.0 #18

Closed
marwinski opened this issue Feb 13, 2018 · 5 comments
Closed

Improve VPN Shoot IP forwarding solution for Calico v3.0 #18

marwinski opened this issue Feb 13, 2018 · 5 comments
Labels
area/networking Networking related component/gardener Gardener kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage)

Comments

@marwinski
Copy link
Contributor

VPN Shoot does not forward packages received via the tunnel device to other pods. The reason for this is simply that IP Forwarding is not turned on.

I found the following in the release notes for Calico:

Host endpoint policies can be applied to forwarded traffic https://docs.projectcalico.org/v3.0/releases/

The new ApplyOnForward flag allows you to specify if a host endpoint policy should apply to forwarded traffic or not. Forwarded traffic includes traffic forwarded between host endpoints and traffic forwarded between a host endpoint and a workload endpoint on the same host. Refer to Using Calico to secure host interfaces for more details.

This will probably do the trick. I have done a simple

echo 1 > /proc/sys/net/ipv4/ip_forward

which also did the trick

@vlerenc vlerenc added the kind/bug Bug label Feb 13, 2018
@rfranzke rfranzke assigned rfranzke and unassigned rfranzke Feb 14, 2018
@rfranzke
Copy link
Contributor

We decided to enable IP forwarding for the vpn-shoot container manually for now (see 6fb8294).
Moreover, due to security reasons, we do not want to globally allow IP forwarding but only for our vpn container.

Actually, we would prefer a solution based on Calico's policy CRDs (https://docs.projectcalico.org/v3.0/reference/calicoctl/resources/globalnetworkpolicy). We need to further invest in a deeper understanding of how calico works internally and how we could achieve that.

@rfranzke rfranzke changed the title VPN Shoot does not work with Calico 3 Improve VPN Shoot IP forwarding solution for Calico v3.0 Feb 14, 2018
rfranzke added a commit to gardener/gardener that referenced this issue Feb 14, 2018
This commits also updates the versions of vpn-seed and vpn-shoot to 0.2.0 which incorporates an important change to cater with the disabled IP forwarding in Calico 3.0 (default); see gardener-attic/vpn#18 for more details.
@vlerenc vlerenc added kind/enhancement Enhancement, improvement, extension and removed kind/bug Bug labels Jun 25, 2018
@vlerenc
Copy link

vlerenc commented Jun 25, 2018

@marwinski Can we do something concrete here?

@vlerenc vlerenc added component/gardener Gardener area/networking Networking related labels Jun 27, 2018
@marwinski
Copy link
Contributor Author

I am not sure on what the intention of @rfranzke and I don't see how those can help in that particular case.

@vlerenc vlerenc added the status/accepted Issue was accepted as something we need to work on label Aug 5, 2018
@gardener-robot-ci-1 gardener-robot-ci-1 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Oct 5, 2018
@gardener-robot-ci-1 gardener-robot-ci-1 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Dec 5, 2018
@gardener-robot-ci-1 gardener-robot-ci-1 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Feb 4, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Apr 6, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jun 6, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Aug 6, 2019
@gardener-robot-ci-2 gardener-robot-ci-2 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Oct 6, 2019
@ghost ghost added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Dec 6, 2019
@ghost ghost added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Feb 5, 2020
@ghost ghost removed the lifecycle/stale Nobody worked on this for 6 months (will further age) label Feb 6, 2020
@ghost ghost added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Apr 6, 2020
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jun 6, 2020
@vlerenc
Copy link

vlerenc commented Aug 13, 2020

@marwinski @zanetworker @DockToFuture @mvladev Please forgive brevity while grooming the backlog. Issue still relevant in the context of the new VPN solution or would you like to close it (it is rotten)?

@vlerenc vlerenc removed the status/accepted Issue was accepted as something we need to work on label Aug 13, 2020
@zanetworker
Copy link
Contributor

zanetworker commented Aug 14, 2020

Closing since we already enable ip-forwarding on the VPN-shoot.

https://github.com/gardener/vpn/blame/70923b7df6726fcb413b6e441f8526588896fd66/shoot/network-connection.sh#L90

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/networking Networking related component/gardener Gardener kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage)
Projects
None yet
Development

No branches or pull requests

7 participants