Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduces file watcher to handle non-TLS->TLS case #627

Closed
wants to merge 1 commit into from
Closed

Introduces file watcher to handle non-TLS->TLS case #627

wants to merge 1 commit into from

Conversation

ishan16696
Copy link
Member

@ishan16696 ishan16696 commented May 18, 2023 •
edited
Loading

What this PR does / why we need it:
This PR introduces file watcher to watch config map which will help in handling non-TLS -> TLS case and call MemberUpdate API only when etcd is up.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Introduces file watcher to handle peerUrl non-TLS -> peerUrl TLS case.

Call `MemberUpdate` API only when etcd is up to update etcd member's peerUrl.

@ishan16696
Introduce file watcher to handle non-TLS -> TLS case.
bef7ebe 
Call updatePeerUrl api call only when etcd is up.
@ishan16696 ishan16696 requested a review from a team as a code owner May 18, 2023 18:34
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels May 18, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 18, 2023
@ishan16696 ishan16696 added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label May 22, 2023
@ishan16696
Copy link
Member Author

I'm closing this PR in a favour of this #628
/close

@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jun 9, 2023
@ishan16696 ishan16696 deleted the fix/updatePeerURL branch June 20, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ishan16696 @gardener-robot-ci-3 @gardener-robot