Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick commits for branch rel-0.24 #630

Merged
merged 1 commit into from
May 25, 2023
Merged

Cherry-pick commits for branch rel-0.24 #630

merged 1 commit into from
May 25, 2023

Conversation

abdasgupta
Copy link
Contributor

What this PR does / why we need it:
This PR cherry-pick commits from the following PR:

  1. Wait for ETCD to be ready before member-update api call - wait for etcd to be ready before continuing with etcd api call #628

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Backup-restore waits for its etcd to be ready before attempting to update peerUrl

@abdasgupta abdasgupta requested a review from a team as a code owner May 25, 2023 07:00
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels May 25, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 25, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 25, 2023
@abdasgupta abdasgupta added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 25, 2023
@aaronfern @abdasgupta
Wait for etcd to be ready before continuing with etcd api call (garde…
2fc0966 
…ner#628)

* wait for etcd to be ready before continuing with memberControl object creation

* address review comments
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 25, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 25, 2023
unmarshall
unmarshall approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@unmarshall unmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels May 25, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 25, 2023
seshachalam-yv
seshachalam-yv approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@seshachalam-yv seshachalam-yv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ishan16696
Copy link
Member

Please update the https://github.com/gardener/etcd-backup-restore/blob/rel-v0.24/VERSION file before merging this

@abdasgupta abdasgupta merged commit 1b1494a into gardener:rel-v0.24 May 25, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 25, 2023
@abdasgupta abdasgupta deleted the rel-v0.24 branch May 25, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unmarshall unmarshall unmarshall approved these changes

@seshachalam-yv seshachalam-yv seshachalam-yv approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@abdasgupta @ishan16696 @unmarshall @seshachalam-yv @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot @aaronfern