Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use distroless images and use user home dir to create files #637

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Use distroless images and use user home dir to create files #637

merged 2 commits into from
Jul 11, 2023

Conversation

aaronfern
Copy link
Contributor

@aaronfern aaronfern commented Jun 19, 2023 •
edited by shreyas-s-rao
Loading

What this PR does / why we need it:
This PR updates etcd-backup-restore to use distroless images and as a result updats file paths of files created by itself to use the user home directory

Which issue(s) this PR fixes:
Fixes #635

Special notes for your reviewer:

Release note:

Etcd-backup-restore now uses a distroless image as its base image. It is no longer compatible with [etcd-custom-image](https://github.com/gardener/etcd-custom-image), and must be used with [etcd-wrapper](https://github.com/gardener/etcd-wrapper) instead. 

Etcd-backup-restore now uses the user home directory to create files.

@aaronfern aaronfern requested a review from a team as a code owner June 19, 2023 12:48
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jun 19, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 19, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 19, 2023
ishan16696
ishan16696 reviewed Jun 26, 2023
View reviewed changes
pkg/server/httpAPI.go Outdated Show resolved Hide resolved
build/Dockerfile Show resolved Hide resolved
shreyas-s-rao
shreyas-s-rao approved these changes Jul 3, 2023
View reviewed changes
Copy link
Collaborator

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaronfern thanks for the PR. I just have one question for you. Other than that, LGTM
/lgtm

build/Dockerfile Show resolved Hide resolved
@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jul 3, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 3, 2023
@shreyas-s-rao shreyas-s-rao self-assigned this Jul 4, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 4, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 4, 2023
@shreyas-s-rao shreyas-s-rao added this to the v0.25.0 milestone Jul 5, 2023
@aaronfern aaronfern added the merge/squash Should be merged via 'Squash and merge' label Jul 7, 2023
shreyas-s-rao
shreyas-s-rao approved these changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
@aaronfern I've taken the liberty to edit the release notes in the PR description.

unmarshall
unmarshall approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@unmarshall unmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@shreyas-s-rao shreyas-s-rao merged commit b3ab2b1 into gardener:master Jul 11, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unmarshall unmarshall unmarshall approved these changes

@shreyas-s-rao shreyas-s-rao shreyas-s-rao approved these changes

@ishan16696 ishan16696 ishan16696 approved these changes

Assignees

@shreyas-s-rao shreyas-s-rao

Labels
merge/squash Should be merged via 'Squash and merge' needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v0.25.0
Development

Successfully merging this pull request may close these issues.

Use distroless:nonroot image for backup-restore
7 participants
@aaronfern @unmarshall @shreyas-s-rao @ishan16696 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot