Fix a full snapshot lease renewal decision #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot
added
needs/review
gardener-robot-ci-1
added
needs/ok-to-test
anveshreddy18
changed the title
ishan16696
approved these changes
Mar 20, 2024
gardener-robot
added
the
status/closed
renormalize
pushed a commit
to renormalize/etcd-backup-restore
that referenced
this pull request
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The recently merged PR #711 had introduced a small change in wrongly deciding that If there's no revision change for full snapshot lease, then don't renew it. But the opposite was originally introduced in PR #410 as a deliberate change so that even if there are no events in the last 24h ( which leads to the current full snapshot having the same revision as previous ) we still want to renew the full snapshot lease because it helps in not marking the full snapshot health check as failed although it was not actually a failure but a case of
skipping the full snapshot( May happen in idle dev shoot clusters in landscapes )Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: